Re: [PATCH] Fixed Cygwin CR-munging problem in mailsplit
On Sun, May 28, 2006 at 12:57:35AM +0400, Zakirov, Salikh wrote:
Show 24 quoted lines
>Junio C Hamano <junkio@cox.net> writes:
>> So even in this modern day, preserving CRLF is not
>> something that happens by default -- you would need to make sure
>> that everybody on your mailpath to the recipient is set up the
>> right way.
>
>> So now I am less in favor of the change than when I wrote that
>> response.
>
>I understand this reasoning, and I am not sure if the fix is correct
>from the "GIT world" point of view.
>
>However, I believe that the command sequence git-format-patch, git-am
>without any e-mail transfer in between and in the same repository
>should work perfectly regardless of the contents of the files,
>no matter if they are binary, text, or "CRLF text" or even
>"broken LF and CRLF text". This is a requirement from a nasty "real
>world".
>
>Junio, could you point at a right place to fix to get git-format-patch,
>git-am sequence work flawlessly on Cygwin?
>
>By the way, the change affects only non-Unix users, as fopen(..., "rt")
>is equivalent to fopen(..., "rb") on all Unixes anyway.
But fopen(..., "r") is not equivalent to fopen(..., "rb") on Cygwin.
Wouldn't you want to add the "b" there to be assured of a binary open?
cgf