[PATCH 1/3] Fix infinite recursion on absolute paths

From: Karl Hasselström <kha@treskal.com>
Date: May 24, 2006, 06:06 UTC
Message-ID: <20060524060643.GA1490@diana.vm.bytemark.co.uk>
In-Reply-To: <20060524060537.GA1173@diana.vm.bytemark.co.uk>

Calling create_dirs with an absolute path caused infinite recursion, since os.path.dirname('/') == '/'. Fix this by exiting early if the given path already is a directory. ---

 stgit/utils.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/stgit/utils.py b/stgit/utils.py
index 68b8f58..ed6e43c 100644
--- a/stgit/utils.py
+++ b/stgit/utils.py
@@ -130,7 +130,7 @@ def remove_file_and_dirs(basedir, file):
 
 def create_dirs(directory):
     """Create the given directory, if the path doesn't already exist."""
-    if directory:
+    if directory and not os.path.isdir(directory):
         create_dirs(os.path.dirname(directory))
         try:
             os.mkdir(directory)