git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Make '@' not valid in a ref name.

From
Shawn Pearce <spearce@spearce.org>
Date
May 21, 2006, 01:58 UTC
Message-ID
<20060521015849.GB7605@spearce.org>
In-Reply-To
<7vodxsywzk.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
> I am not a fan of retroactively disallowing what we used to
> allow.  Is this unavoidable?
>

We're talking about it on #git right now. Someone actually uses refs like 'user@host/foo' and thus doesn't like this patch either.

We were talking about disallowing '@{' instead. Really its just '@{<some run that smells like a date}' at the end of the ref which would want to be disallowed; similiar to how ~ and ^ really only need to be disallowed near the end.

The date parser grabs '@{' not '@' so 'user@host/foo@{yesterday}' makes sense to it. But 'user@{host}/foo@{yesterday}' is going to cause problems as the date parser will attempt to evaluate 'host}/foo@{yesterday'. :-(

-- 
Shawn.
Previous: Junio C HamanoNext: Eric Wong
Message 3 of 5 in “Make '@' not valid in a ref name.”
  1. Make '@' not valid in a ref name.Shawn Pearce, May 21, 2006
  2. Junio C HamanoMay 21, 2006
  3. Shawn PearceMay 21, 2006
  4. Eric WongMay 21, 2006
  5. Shawn PearceMay 21, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.