Re: [PATCH] Transitively read alternatives
- From
Martin Waitz <tali@admingilde.org>
- Date
- May 3, 2006, 07:51 UTC
- Message-ID
- <20060503075133.GO20847@admingilde.org>
- In-Reply-To
- <7v8xpjhguu.fsf@assigned-by-dhcp.cox.net>
hoi :)
On Tue, May 02, 2006 at 09:28:25PM -0700, Junio C Hamano wrote:
Show 6 quoted lines
> > + if (*entry != '/' && relative_base) {
> > + /* Relative alt-odb */
> > + if (base_len < 0)
> > + base_len = strlen(relative_base) + 1;
>
> Wouldn't base_len be always -1 here?hmm, I just moved that part around.
> Maybe it is easier not to do the recursive thing unless the alternate > is absolute path, and also as a purely safety measure, limit the > maximum recursion depth to something low like 5, similar to recursive > symlink resolution.
Agreed. Lets see if I have some free time in the evening ;-)
-- Martin Waitz