Re: git-log produces no output
- From
- Bob Portmann <bportmann@yahoo.com>
- Date
- Apr 21, 2006, 19:38 UTC
- Message-ID
- <20060421193808.57328.qmail@web60314.mail.yahoo.com>
- In-Reply-To
- <Pine.LNX.4.64.0604211223561.3701@g5.osdl.org>
Yes, that fixes it, even with the crazy PAGER (which is going to be plain 'more' from now on:-)
Thanks, Bob
--- Linus Torvalds <torvalds@osdl.org> wrote:
Show 32 quoted lines
> On Fri, 21 Apr 2006, Linus Torvalds wrote:
> >
> > This patch would have made things a lot more obvious.
>
> Actually, scratch that one, and use this one instead. Much better,
> and
> actually allows Bob's crazy PAGER environment variable to work,
> rather
> than just reporting an error about it.
>
> Linus
> ---
> diff --git a/pager.c b/pager.c
> index b063353..9a30939 100644
> --- a/pager.c
> +++ b/pager.c
> @@ -8,6 +8,7 @@ #include "cache.h"
> static void run_pager(const char *pager)
> {
> execlp(pager, pager, NULL);
> + execl("/bin/sh", "sh", "-c", pager, NULL);
> }
>
> void setup_pager(void)
> @@ -47,5 +48,6 @@ void setup_pager(void)
>
> setenv("LESS", "-S", 0);
> run_pager(pager);
> + die("unable to execute pager '%s'", pager);
> exit(255);
> }
> __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com