git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[BUG] comments in grafts file broken in current master

From
Yann Dirson <ydirson@altern.org>
Date
Apr 16, 2006, 12:35 UTC
Message-ID
<20060416123535.GT12638@nowhere.earth>

While looking at allowing empty lines in grafts files, I discovered that comments had already been implemented. However, current git-read-tree segfaults when there is a comment line in info/grafts:

dwitch@gandelf:/export/work/yann/git/git$ cat .git/info/grafts c118c026e44f02c3dbad00d924285eef2340f700 # foo dwitch@gandelf:/export/work/yann/git/git$ git-read-tree master Segmentation fault

The commit introducing the problem is
5040f17eba15504bad66b14a645bddd9b015ebb7 (blame -S <ancestry-file>),
which changes quite some things in the grafts area.
    

BTW, after segfaulting, .git/index.lock is still there, and the "unable to create new cachefile" is not so helpful - I had to strace to see what was happenning.

Hope this helps,
-- 
Yann Dirson    <ydirson@altern.org> |
Debian-related: <dirson@debian.org> |   Support Debian GNU/Linux:
                                    |  Freedom, Power, Stability, Gratis
     http://ydirson.free.fr/        | Check <http://www.debian.org/>
Next: Junio C Hamano
Message 1 of 2 in “[BUG] comments in grafts file broken in current master”
  1. Yann DirsonApr 16, 2006
  2. reading $GIT_DIR/info/graft - skip comments correctly.Junio C Hamano, Apr 16, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.