git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Bug encountered while comitting

From
MKMatthias Kestenholz <lists@irregular.ch>
Date
Mar 25, 2006, 10:23 UTC
Message-ID
<20060325102314.GA3825@spinlock.ch>
In-Reply-To
<7vwtejxd3u.fsf@assigned-by-dhcp.cox.net>
* Junio C Hamano (junkio@cox.net) wrote:
Show 22 quoted lines
> You are right.  commit-tree does not seem to check if it
> successfully wrote the commit object.  How about this?
> 
> -- >8 --
> diff --git a/commit-tree.c b/commit-tree.c
> index 88871b0..16c1787 100644
> --- a/commit-tree.c
> +++ b/commit-tree.c
> @@ -125,7 +125,10 @@ int main(int argc, char **argv)
>  	while (fgets(comment, sizeof(comment), stdin) != NULL)
>  		add_buffer(&buffer, &size, "%s", comment);
>  
> -	write_sha1_file(buffer, size, "commit", commit_sha1);
> -	printf("%s\n", sha1_to_hex(commit_sha1));
> -	return 0;
> +	if (!write_sha1_file(buffer, size, "commit", commit_sha1)) {
> +		printf("%s\n", sha1_to_hex(commit_sha1));
> +		return 0;
> +	}
> +	else
> +		return 1;
>  }

This patch fixes the problem I was encountering (git-update-ref is not executed anymore).

Thank you all for this really great tool!
-- 
:wq
Previous: Junio C Hamano
Message 7 of 7 in “Bug encountered while comitting”
  1. Matthias KestenholzMar 24, 2006
  2. Andreas EricssonMar 24, 2006
  3. Matthias KestenholzMar 25, 2006
  4. Junio C HamanoMar 24, 2006
  5. Matthias KestenholzMar 25, 2006
  6. Junio C HamanoMar 25, 2006
  7. Matthias KestenholzMar 25, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.