Re: [BUG] make test (t3600-rm.sh) fails

From: Petr Baudis <pasky@suse.cz>
Date: Mar 24, 2006, 13:51 UTC
Message-ID: <20060324135102.GX18185@pasky.or.cz>
In-Reply-To: <4423E06E.9090004@issaris.org>

Dear diary, on Fri, Mar 24, 2006 at 01:05:02PM CET, I got a letter where Panagiotis Issaris <takis@issaris.org> said that...

Show 9 quoted lines

> diff --git a/t/t3600-rm.sh b/t/t3600-rm.sh
> index d1947e1..52a1e99 100755
> --- a/t/t3600-rm.sh
> +++ b/t/t3600-rm.sh
> @@ -56,6 +56,7 @@ test "$test_tabs" = y && test_expect_suc
>     "git-rm -f 'space embedded' 'tab   embedded' 'newline
> embedded'"
> 
> +if test `whoami` != "root"; then

Root is not the only condition when this will not fail, it can happen on broken filesystems as well, specifically AFS. (Avoid avoid avoid that horrid thing!)

So, perhaps rather

> if test "$test_tabs" = y; then
> chmod u-w .

+ touch xyzzy || \

> test_expect_failure \

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Right now I am having amnesia and deja-vu at the same time.  I think
I have forgotten this before.