Re: [RFC] Silent File Mods Being Committed

From: Petr Baudis <pasky@suse.cz>
Date: Mar 24, 2006, 01:12 UTC
Message-ID: <20060324011217.GP19263@pasky.or.cz>
In-Reply-To: <7vk6ak4tzp.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Fri, Mar 24, 2006 at 12:32:58AM CET, I got a letter where Junio C Hamano <junkio@cox.net> said that...

Show 19 quoted lines

> Petr Baudis <pasky@suse.cz> writes:
> 
> > Dear diary, on Thu, Mar 23, 2006 at 06:13:21AM CET, I got a letter
> > where Junio C Hamano <junkio@cox.net> said that...
> >>  (2) audit all the scripts to make sure they do not get upset if
> >>      we add trailing +/- to the status letter, and do that
> >>      unconditionally, like the attached patch does.
> >
> > Cogito will get upset since we assume the mode field is one-char in our
> > regexps, and when we don't, we compare the mode field with strings and
> > that would obviously fail if you add random stuff to it.
> >
> > Otherwise, I like this idea, though.
> 
> Likewise.  If it was not obvious, I am not going to commit that
> myself.  If jdl or somebody cares enough, he or she can prepare
> a a set of patches to git-core, Cogito and StGIT (at least these
> three should be covered) to teach them the trailing +/- letter,
> _and_ parrot my patch back at me.  Hint, hint...

Well, or it can just add the option to Core Git. Just unconditional implementation of (2) is no-go because it would break backwards compatibility, which is baaad.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Right now I am having amnesia and deja-vu at the same time.  I think
I have forgotten this before.