Re: [BUG] imap-send.c fails to build on OSX

From: Shawn Pearce <spearce@spearce.org>
Date: Mar 13, 2006, 05:03 UTC
Message-ID: <20060313050338.GA18154@spearce.org>
In-Reply-To: <86zmjvhsru.fsf@blue.stonehenge.com>

"Randal L. Schwartz" <merlyn@stonehenge.com> wrote:

Show 15 quoted lines

> >>>>> "Shawn" == Shawn Pearce <spearce@spearce.org> writes:
> 
> Shawn> Workarounds for compiling on MacOS X.
> Shawn> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
> 
> Shawn>  This should fix the build issues on Mac OS X.  Not tested on other
> Shawn>  (possibly) more important platforms, like Linux.  :-)
> 
> My C is a bit rusty, but wouldn't that provide a definition for vasprintf when
> the libc is *also* providing a definition?  Might that not also break other
> apps that want to link with this?
> 
> Maybe the right solution is to rename this local implementation so that it
> can't conflict, like "git_vasprintf", or to include it only when the libc
> doesn't provide it.

Your right. But I figured it wasn't a big deal since this is just an application and not library code. Nobody should be linking against it.

Perhaps the better solution is to rename the provided implementation to git_; maybe even better to move it off to the compat library area where other should-have-been-provided-by-the-OS definitions are.

-- 
Shawn.