git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] contrib/git-svn: remove the --no-stop-on-copy flag

From
EWEric Wong <normalperson@yhbt.net>
Date
Mar 9, 2006, 11:50 UTC
Message-ID
<20060309115034.GB11934@localdomain>
In-Reply-To
<20060308014207.GA31137@localdomain>

Output a big warning if somebody actually has a pre-1.0 version of svn that doesn't support it.

Thanks to Yann Dirson for reminding me it still existed and attempting to re-enable it :)

I think I subconciously removed support for it earlier...
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 contrib/git-svn/git-svn.perl |   11 +++++++++++
 contrib/git-svn/git-svn.txt  |   13 -------------
 2 files changed, 11 insertions(+), 13 deletions(-)
0ec45e489232fad4f1aa3d2c648fa53295efd7ec
diff --git a/contrib/git-svn/git-svn.perl b/contrib/git-svn/git-svn.perl
index dca4e5c..43b50ec 100755
--- a/contrib/git-svn/git-svn.perl
+++ b/contrib/git-svn/git-svn.perl
@@ -1019,6 +1019,17 @@ sub svn_compat_check {
 	if (grep /usage: checkout URL\[\@REV\]/,@co_help) {
 		$_svn_co_url_revs = 1;
 	}
+
+	# I really, really hope nobody hits this...
+	unless (grep /stop-on-copy/, (safe_qx(qw(svn log -h)))) {
+		print STDERR <<'';
+W: The installed svn version does not support the --stop-on-copy flag in
+   the log command.
+   Lets hope the directory you're tracking is not a branch or tag
+   and was never moved within the repository...
+
+		$_no_stop_copy = 1;
+	}
 }
 
 # *sigh*, new versions of svn won't honor -r<rev> without URL@<rev>,
diff --git a/contrib/git-svn/git-svn.txt b/contrib/git-svn/git-svn.txt
index 5fb5b7c..7a6e0c4 100644
--- a/contrib/git-svn/git-svn.txt
+++ b/contrib/git-svn/git-svn.txt
@@ -162,19 +162,6 @@ COMPATIBILITY OPTIONS
 	Otherwise, do not enable this flag unless you know what you're
 	doing.
 
---no-stop-on-copy::
-	Only used with the 'fetch' command.
-
-	By default, git-svn passes --stop-on-copy to avoid dealing with
-	the copied/renamed branch directory problem entirely.  A
-	copied/renamed branch is the result of a <SVN_URL> being created
-	in the past from a different source.  These are problematic to
-	deal with even when working purely with svn if you work inside
-	subdirectories.
-
-	Do not use this flag unless you know exactly what you're getting
-	yourself into.  You have been warned.
-
 Basic Examples
 ~~~~~~~~~~~~~~
 
-- 
1.2.4.ga2910
Previous: Yann DirsonNext: Matthias Urlichs
Message 8 of 9 in “git-svn, tree moves, and --no-stop-on-copy”
  1. Yann DirsonMar 7, 2006
  2. Eric WongMar 8, 2006
  3. contrib/git-svn: fix UUID reading w/pre-1.2 svn; fetch argsEric Wong, Mar 8, 2006
  4. Junio C HamanoMar 9, 2006
  5. contrib/git-svn: fix svn compat and fetch argsEric Wong, Mar 9, 2006
  6. Yann DirsonMar 8, 2006
  7. Yann DirsonMar 8, 2006
  8. contrib/git-svn: remove the --no-stop-on-copy flagEric Wong, Mar 9, 2006
  9. Matthias UrlichsMar 8, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.