[PATCH] contrib/git-svn: remove the --no-stop-on-copy flag
- From
- Eric Wong <normalperson@yhbt.net>
- Date
- Mar 9, 2006, 11:50 UTC
- Message-ID
- <20060309115034.GB11934@localdomain>
- In-Reply-To
- <20060308014207.GA31137@localdomain>
Output a big warning if somebody actually has a pre-1.0 version of svn that doesn't support it.
Thanks to Yann Dirson for reminding me it still existed and attempting to re-enable it :)
I think I subconciously removed support for it earlier...
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
contrib/git-svn/git-svn.perl | 11 +++++++++++ contrib/git-svn/git-svn.txt | 13 ------------- 2 files changed, 11 insertions(+), 13 deletions(-)
0ec45e489232fad4f1aa3d2c648fa53295efd7ec
diff --git a/contrib/git-svn/git-svn.perl b/contrib/git-svn/git-svn.perl index dca4e5c..43b50ec 100755 --- a/contrib/git-svn/git-svn.perl +++ b/contrib/git-svn/git-svn.perl @@ -1019,6 +1019,17 @@ sub svn_compat_check { if (grep /usage: checkout URL\[\@REV\]/,@co_help) { $_svn_co_url_revs = 1; } + + # I really, really hope nobody hits this... + unless (grep /stop-on-copy/, (safe_qx(qw(svn log -h)))) { + print STDERR <<''; +W: The installed svn version does not support the --stop-on-copy flag in + the log command. + Lets hope the directory you're tracking is not a branch or tag + and was never moved within the repository... + + $_no_stop_copy = 1; + } } # *sigh*, new versions of svn won't honor -r<rev> without URL@<rev>, diff --git a/contrib/git-svn/git-svn.txt b/contrib/git-svn/git-svn.txt index 5fb5b7c..7a6e0c4 100644 --- a/contrib/git-svn/git-svn.txt +++ b/contrib/git-svn/git-svn.txt @@ -162,19 +162,6 @@ COMPATIBILITY OPTIONS Otherwise, do not enable this flag unless you know what you're doing. ---no-stop-on-copy:: - Only used with the 'fetch' command. - - By default, git-svn passes --stop-on-copy to avoid dealing with - the copied/renamed branch directory problem entirely. A - copied/renamed branch is the result of a <SVN_URL> being created - in the past from a different source. These are problematic to - deal with even when working purely with svn if you work inside - subdirectories. - - Do not use this flag unless you know exactly what you're getting - yourself into. You have been warned. - Basic Examples ~~~~~~~~~~~~~~
-- 1.2.4.ga2910