Re: [PATCH] annotate: Support annotation of files on other revisions.

From: Shawn Pearce <spearce@spearce.org>
Date: Mar 6, 2006, 05:50 UTC
Message-ID: <20060306055036.GB26820@spearce.org>
In-Reply-To: <440BCB67.4070406@michonline.com>

Ryan Anderson <ryan@michonline.com> wrote:

Show 22 quoted lines

> A Large Angry SCM wrote:
> 
> > Ryan Anderson wrote:
> > ...
> >
> >>
> >> For annotate, the syntax I was using was:
> >>     git annotate Makefile headname
> >>
> >> I'm not married to it, so please, send a patch to change it if you want
> >> (Please fix up the test case I'm sending in this patch, as well.)
> >>
> >
> > Wouldn't
> >     git annotate <headname> <filename(s?)>
> > be more consistent with other git commands?
> >
> Yes, but <headname> (really, a commitish) needs to be optional.
> 
> I should probably switch to:
>     git annotate [-c|--commit <committish>] <filename>
> but that's partly why I'm asking for feedback.

Yes but doesn't git-diff accept:

	git-diff Makefile
	git-diff HEAD Makefile

? (Which is rather ugly as what if you have a tracked file actually called HEAD and you want the first form when the commit-ish is omitted.) So accepting an optional commit-ish before the filename would be in line with what git-diff accepts today.

But maybe breaking convention from git-diff now is a good thing, with a future change to cleanup git-diff.

-- 
Shawn.