Re: What's in git.git

From: Luck, Tony <tony.luck@intel.com>
Date: Mar 1, 2006, 23:01 UTC
Message-ID: <20060301230153.GA32286@agluck-lia64.sc.intel.com>
In-Reply-To: <7vmzgagxox.fsf@assigned-by-dhcp.cox.net>

On Wed, Mar 01, 2006 at 04:24:14AM -0800, Junio C Hamano wrote:

> * The 'master' branch has these since the last announcement.
>   - compilation warning fixes (Timo Hirvonen, Tony Luck, Andreas Ericsson)

In commit 8fcf1ad9c68e15d881194c8544e7c11d33529c2b you put in a combination of my double cast and Andreas' switch to using unsigned long ... just the latter is sufficient (and a lot less ugly than using the double cast).

Signed-off-by: Tony Luck <tony.luck@intel.com>

--

diff --git a/pack-objects.c b/pack-objects.c
index 21ee572..136a7f5 100644
--- a/pack-objects.c
+++ b/pack-objects.c
@@ -99,7 +99,7 @@ static int reused_delta = 0;
 
 static int pack_revindex_ix(struct packed_git *p)
 {
-	unsigned long ui = (unsigned long)(long)p;
+	unsigned long ui = (unsigned long)p;
 	int i;
 
 	ui = ui ^ (ui >> 16); /* defeat structure alignment */