Re: New shiny gitk

From: Sergey Vlasov <vsu@altlinux.ru>
Date: Feb 19, 2006, 20:12 UTC
Message-ID: <20060219231215.545b1537.vsu@altlinux.ru>
In-Reply-To: <17400.23434.724188.649656@cargo.ozlabs.ibm.com>

On Sun, 19 Feb 2006 22:50:34 +1100 Paul Mackerras wrote:

Show 8 quoted lines

> I just created a branch called "new" in my gitk repository at
> 
> git://git.kernel.org/pub/scm/gitk/gitk.git
> 
> which has a new improved version of gitk which is much faster than the
> old one and has a better graph layout algorithm.  I'd like people to
> try it out and tell me how they like it and if I broke anything (I'm
> pretty sure I broke the "Update" function, for instance).

I have found a case where the new algorithm produces much worse layout than before.

I cloned the Linus' kernel tree:

   git clone git://www.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git linux-2.6

then fetched the Ubuntu tree:

   git fetch git://www.kernel.org/pub/scm/linux/kernel/git/bcollins/ubuntu-2.6.git master:ubuntu

then tried to look at Ubuntu changes:

  gitk origin..ubuntu

The old algorithm was producing a graph with less than 20 lines on the left, so the patch description was visible. The new version, however, produces something which does not fit even on a 1920x1200 screen (look at the bottom of the graph).

> If you use -d to get commits ordered by date, you will need the latest
> version of git-rev-list, which has the --date-order option.

I tried this option - it changes some things, but does not fix that layout problem.