git/list[1] front-page[2] threads[3] people[4] search[5] about
 

gitk patch display corner-case bug

From
Karl Hasselström <kha@treskal.com>
Date
Feb 18, 2006, 23:36 UTC
Message-ID
<20060218233618.GA29025@diana.vm.bytemark.co.uk>
In a recently updated stgit tree,
  $ git-diff 51cb39db\^ 51cb39db
  diff --git a/templates/covermail.tmpl b/templates/covermail.tmpl
  index 9789c9c..44cd19e 100644
  --- a/templates/covermail.tmpl
  +++ b/templates/covermail.tmpl
  @@ -4,5 +4,5 @@ Date: %(date)s
   %(endofheaders)s
   The following series implements...
   
  ---
  +-- 
   Signature

That is, a trailing whitespace was added after the two dashes. However, gitk displays this as

  index 9789c9c..44cd19e 100644
  @@ -2,7 +2,7 @@ From: %(maintainer)s
   Subject: [PATCH%(version)s%(number)s] Series short description
   Date: %(date)s
   %(endofheaders)s
   The following series implements...
   
  +-- 
   Signature

Totally correct except that it omitted the line consisting of only three dashes.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle
Next: Paul Mackerras
Message 1 of 3 in “gitk patch display corner-case bug”
  1. Karl HasselströmFeb 18, 2006
  2. Paul MackerrasFeb 19, 2006
  3. Karl HasselströmFeb 19, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.