git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-svn: fix revision order when XML::Simple is not loaded

From
EWEric Wong <normalperson@yhbt.net>
Date
Feb 16, 2006, 19:47 UTC
Message-ID
<20060216194751.GB4446@Muzzle>
In-Reply-To
<20060216073826.GA12055@hand.yhbt.net>
Thanks to Emmanuel Guerin for finding the bug.
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 contrib/git-svn/git-svn |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
98de7584b4991ab9c4025e36bfbfc10eacd17b8d
diff --git a/contrib/git-svn/git-svn b/contrib/git-svn/git-svn
index 62fc14f..ddd9579 100755
--- a/contrib/git-svn/git-svn
+++ b/contrib/git-svn/git-svn
@@ -523,7 +523,7 @@ sub svn_log_raw {
 
 			# if we have an empty log message, put something there:
 			if (@svn_log) {
-				$svn_log[0]->{msg} ||= "\n";
+				$svn_log[$#svn_log]->{msg} ||= "\n";
 			}
 			next;
 		}
@@ -538,7 +538,7 @@ sub svn_log_raw {
 					date => "$tz $Y-$m-$d $H:$M:$S",
 					author => $author,
 					msg => '' );
-			unshift @svn_log, \%log_msg;
+			push @svn_log, \%log_msg;
 			$state = 'msg_start';
 			next;
 		}
@@ -546,7 +546,7 @@ sub svn_log_raw {
 		if ($state eq 'msg_start' && /^$/) {
 			$state = 'msg';
 		} elsif ($state eq 'msg') {
-			$svn_log[0]->{msg} .= $_."\n";
+			$svn_log[$#svn_log]->{msg} .= $_."\n";
 		}
 	}
 	close $log_fh or croak $?;
-- 
1.2.0.gdee6
Previous: Eric WongNext: Eric Wong
Message 13 of 15 in “[ANNOUNCE] git-svn - bidirection operations between svn and git”
  1. Eric WongFeb 16, 2006
  2. Junio C HamanoFeb 16, 2006
  3. Aneesh KumarFeb 16, 2006
  4. Junio C HamanoFeb 16, 2006
  5. Aneesh KumarFeb 16, 2006
  6. Junio C HamanoFeb 16, 2006
  7. Aneesh KumarFeb 16, 2006
  8. Petr BaudisFeb 16, 2006
  9. Aneesh KumarFeb 16, 2006
  10. Eric WongFeb 16, 2006
  11. Eduardo Pereira HabkostFeb 16, 2006
  12. Eric WongFeb 16, 2006
  13. git-svn: fix revision order when XML::Simple is not loadedEric Wong, Feb 16, 2006
  14. Eric WongFeb 16, 2006
  15. git-svn: ensure fetch always works chronologically.Eric Wong, Feb 17, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.