git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix HTTP request result processing after slot reuse

From
NHNick Hengeveld <nickh@reactrix.com>
Date
Feb 1, 2006, 01:50 UTC
Message-ID
<20060201015047.GF3873@reactrix.com>
In-Reply-To
<7v64o0ulfu.fsf@assigned-by-dhcp.cox.net>
On Tue, Jan 31, 2006 at 01:39:01PM -0800, Junio C Hamano wrote:
> These static variables are probably correct, provided if
> fetch_index, fetch_indices and friends do not recurse into
> themselves, but it just gives me this funny feeling...

It's true that in the current implementation we either don't recurse into these functions or we explicitly handle cases where we do such as fetch_alternates. However, I've got no argument as to why the structures should be static and can imagine it just causing problems down the road if we were to eg. start downloading multiple packs concurrently.

I'll follow up with a patch.

-- For a successful technology, reality must take precedence over public relations, for nature cannot be fooled.

Previous: Junio C Hamano
Message 3 of 3 in “Fix HTTP request result processing after slot reuse”
  1. Fix HTTP request result processing after slot reuseNick Hengeveld, Jan 31, 2006
  2. Junio C HamanoJan 31, 2006
  3. Nick HengeveldFeb 1, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.