Re: [PATCH] Lower priority of Cogito's default exclude patterns

From: Karl Hasselström <kha@treskal.com>
Date: Jan 19, 2006, 14:07 UTC
Message-ID: <20060119140728.GA14998@diana.vm.bytemark.co.uk>
In-Reply-To: <20060119124244.GJ27976@pasky.or.cz>

On 2006-01-19 13:42:44 +0100, Petr Baudis wrote:

Show 26 quoted lines

> Dear diary, on Thu, Jan 19, 2006 at 11:07:12AM CET, I got a letter
> where Karl Hasselström <kha@treskal.com> said that...
>
> > On 2006-01-07 23:19:31 +0100, Karl Hasselström wrote:
> >
> > > Put the default exclude patterns in a file referenced with
> > > --exclude-from, instead of on the command line with --exclude.
> > > (The existing behavior was bad since --exclude has higher
> > > priority than --exclude-from and --exclude-per-directory, which
> > > made it impossible for the user to override the default
> > > patterns.)
> > >
> > > Signed-off-by: Karl Hasselström <kha@treskal.com>
> > >
> > > ---
> > >
> > >  Makefile           |   15 +++++++++++++--
> > >  cg-Xlib            |    6 +++++-
> > >  cg-default-exclude |    6 ++++++
> > >  3 files changed, 24 insertions(+), 3 deletions(-)
> >
> > Did you miss this patch, or just not like it?
>
> Just postponed for next sweep through my patch queue, due today or
> tomorrow. ;) I will rename cg-default-exclude to default-exclude,
> though.

Good point.

> Oh, now I remember - one my major concern is that now Cogito will
> not work if not make install'd, which is how I actually primarily
> use it on my machine.

The not-installed case could easily be worked around by users if cogito looked at /etc/cogito/exclude and ~/.cogito/exclude as well. (Or maybe that should be /etc/git/exclude and ~/.gitexclude, so that e.g. stgit can use the same files.) Would you accept a patch that did this?

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle