git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] cg-seek should not complain if run twice

From
PRPavel Roskin <proski@gnu.org>
Date
Jan 15, 2006, 06:03 UTC
Message-ID
<20060115010335.dj4swocs000k008o@webmail.spamcop.net>
In-Reply-To
<20060114233037.GA28365@pasky.or.cz>
Hello, Petr!
Quoting Petr Baudis <pasky@suse.cz>:
> It seems cleaner to just make cg-seek fail with a sensible error message
> if it's already unseeked.

I don't like this. What if "cvs up -A" would fail if run twice? What if cg-clean would fail if there was nothing to clean? What if sync would fail if it didn't cause a single disk write? Idempotent operations are easier to work with. Please see http://en.wikipedia.org/wiki/Idempotent_(software)

I could make an exception for the case when the command invocation indicates that the user is unaware of something, and that it would endanger the user's data. But it's not the case for cg-seek without arguments on non-seeked repository. The intention is clear, and the knowledge of the current state of the repository doesn't matter, since there will be no merge or something.

-- Regards, Pavel Roskin

Previous: Petr BaudisNext: Petr Baudis
Message 3 of 4 in “cg-seek should not complain if run twice”
  1. cg-seek should not complain if run twicePavel Roskin, Dec 20, 2005
  2. Petr BaudisJan 14, 2006
  3. Pavel RoskinJan 15, 2006
  4. Petr BaudisJan 15, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.