git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-grep: convert from bash to sh

From
THTimo Hirvonen <tihirvon@gmail.com>
Date
Dec 18, 2005, 13:26 UTC
Message-ID
<20051218152639.5c14bc26.tihirvon@gmail.com>
sh does not support arrays so we have to use eval instead.
Signed-off-by: Timo Hirvonen <tihirvon@gmail.com>
---
 git-grep.sh |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)
11c29a066288c5f05a67ff0d46e9ce17cd7a37da
diff --git a/git-grep.sh b/git-grep.sh
index 2ed8e95..2f0a297 100755
--- a/git-grep.sh
+++ b/git-grep.sh
@@ -8,21 +8,21 @@ SUBDIRECTORY_OK='Yes'
 . git-sh-setup
 
 pattern=
-flags=()
-git_flags=()
+flags=
+git_flags=
 while : ; do
 	case "$1" in
 	--cached|--deleted|--others|--killed|\
 	--ignored|--exclude=*|\
 	--exclude-from=*|\--exclude-per-directory=*)
-		git_flags=("${git_flags[@]}" "$1")
+		git_flags="$git_flags '$1'"
 		;;
 	-e)
 		pattern="$2"
 		shift
 		;;
 	-A|-B|-C|-D|-d|-f|-m)
-		flags=("${flags[@]}" "$1" "$2")
+		flags="$flags '$1' '$2'"
 		shift
 		;;
 	--)
@@ -31,7 +31,7 @@ while : ; do
 		break
 		;;
 	-*)
-		flags=("${flags[@]}" "$1")
+		flags="$flags '$1'"
 		;;
 	*)
 		if [ -z "$pattern" ]; then
@@ -46,5 +46,5 @@ done
 [ "$pattern" ] || {
 	usage
 }
-git-ls-files -z "${git_flags[@]}" "$@" |
-	xargs -0 grep "${flags[@]}" -e "$pattern"
+eval git-ls-files -z "$git_flags" '"$@"' |
+	eval xargs -0 grep "$flags" -e '"$pattern"'
-- 
0.99.9.GIT
Next: Petr Baudis
Message 1 of 5 in “git-grep: convert from bash to sh”
  1. git-grep: convert from bash to shTimo Hirvonen, Dec 18, 2005
  2. Petr BaudisDec 18, 2005
  3. Junio C HamanoDec 18, 2005
  4. Linus TorvaldsDec 18, 2005
  5. Timo HirvonenDec 18, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.