Re: How to clone-pack the HEAD?

From: Petr Baudis <pasky@suse.cz>
Date: Dec 18, 2005, 00:53 UTC
Message-ID: <20051218005306.GU22159@pasky.or.cz>
In-Reply-To: <7vfyouricc.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Thu, Dec 15, 2005 at 07:21:23AM CET, I got a letter where Junio C Hamano <junkio@cox.net> said that...

Show 13 quoted lines

> Junio C Hamano <junkio@cox.net> writes:
> 
> > Also I might want to give --keep option to fetch-pack as well;
> > clone-pack has some static functions that we can extract out to
> > a common file to link to both.
> 
> And this is the second installment, on top of the previous one.
> I am a bit reluctant about this one only because of its size,
> but I suspect it may be much easier to use for your purpose.
> 
> I'll keep this in the proposed updates branch for now (the other
> one goes to master tonight), so if you like this one, please
> holler, test out and ack.

Well, I like this one, but you don't need to put this to master just for me, I'm perfectly fine with the git-clone-pack fix - both commands are now equally simple for me to use in Cogito. (And both seem to work fine after some basic testing.)

But you are right that git-clone-pack is basically made obsolete by this patch, and I tend to like that fact - that's why I have slight preference to this patch anyway, despite its size (and it's mostly common code being moved around anyway). It's probably too late to remove git-clone-pack altogether, but you might at least deprecate it and print a warning when it's being ran (or at least please print a warning when it's being ran in a repository which is already populated, which is very likely a driver error, and I've actually made it just a minute ago ;).

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.