Re: git cole give unexpected error message

From: Petr Baudis <pasky@suse.cz>
Date: Dec 14, 2005, 11:41 UTC
Message-ID: <20051214114156.GG22159@pasky.or.cz>
In-Reply-To: <439FE7AD.6080602@op5.se>

Dear diary, on Wed, Dec 14, 2005 at 10:36:45AM CET, I got a letter where Andreas Ericsson <ae@op5.se> said that...

Show 18 quoted lines

> Petr Baudis wrote:
> >Dear diary, on Tue, Dec 13, 2005 at 10:28:20PM CET, I got a letter
> >where Sam Ravnborg <sam@ravnborg.org> said that...
> >
> >>cogito being a nice porcelain gives the git errormessage but manage to
> >>clean up when the clone fails.
> >>So also cogito would benefit from a more descriptive errormessage.
> >
> >
> >Well, git clone can fail for many reasons and I don't think the "no such
> >repository" one is completely overwhelming, so hinting that by Cogito
> >could be quite confusing (theme of the day: usability ;-)).
> >
> >The real solution would be proper error reporting by the git daemon.
> >
> 
> But that would open up for an information disclosure. If someone's 
> hacking on a patch, please make it configurable at least.

When it breaks at this stage, it's either some bad internal error (I guess memory allocation error might do this), permission problem, or repository not being found. We might then report a more generic error message "Repository not found or access denied.".

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.