git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] [COGITO] make cg-tag use git-check-ref-format

From
MAMartin Atukunda <matlads@dsmagic.com>
Date
Dec 13, 2005, 11:28 UTC
Message-ID
<200512131428.45273.matlads@dsmagic.com>
In-Reply-To
<7vy82p9rnb.fsf@assigned-by-dhcp.cox.net>
On Tuesday 13 December 2005 14:13, Junio C Hamano wrote:
Show 13 quoted lines
> Martin Atukunda <matlads@dsmagic.com> writes:
> > The egrep pattern used by cg-tag is too restrictive. While it will
> > prevent control characters from being specified as a tag name, it will
> > also reject nearly anything written in a non-English language, as noted
> > by -hpa ...
> > -(echo $name | egrep -qv '[^a-zA-Z0-9_.@!:-]') || \
> > +git-check-ref-format $name || \
> >  	die "name contains invalid characters"
>
> Perhaps you meant to say:
>
> 	git-check-ref-format "$name"
>

Yes. i've just finished preparing a new patch with this exact change. But your patch is much better.

- Martin -
-- 
Due to a shortage of devoted followers, the production of great leaders has 
been discontinued.
Previous: Junio C HamanoNext: Petr Baudis
Message 3 of 9 in “[COGITO] make cg-tag use git-check-ref-format”
  1. [COGITO] make cg-tag use git-check-ref-formatMartin Atukunda, Dec 13, 2005
  2. Junio C HamanoDec 13, 2005
  3. Martin AtukundaDec 13, 2005
  4. Petr BaudisDec 13, 2005
  5. Junio C HamanoDec 13, 2005
  6. Alex RiesenDec 15, 2005
  7. Junio C HamanoDec 15, 2005
  8. Junio C HamanoDec 16, 2005
  9. Petr BaudisDec 16, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.