git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] cg-clean: fix directory cleaning

From
Petr Baudis <pasky@suse.cz>
Date
Dec 13, 2005, 00:42 UTC
Message-ID
<20051213004251.GA22159@pasky.or.cz>
In-Reply-To
<1134420860.4695.14.camel@dv>

Dear diary, on Mon, Dec 12, 2005 at 09:54:20PM CET, I got a letter where Pavel Roskin <proski@gnu.org> said that...

Show 10 quoted lines
> cg-clean is broken by commit 3cddede46dcd24bd7c36827ca564de23b2bb3517 -
> it removes all subdirectories when run in the top level directory.
> 
> Although it's easy to make a one-line fix, I'd prefer a solution that
> makes cg-clean potentially safer.  Since git-ls-files runs in
> subdirectories now, it's no longer needed to run anything in the top
> level directory and filter out the results.  cg-clean now changes to
> $_git_relpath on startup and never uses $_git_relpath again.
> 
> Signed-off-by: Pavel Roskin <proski@gnu.org>

Oops! Many thanks to both this and the testcase - I was just about to write one, because those cg-clean bugs are really quite ugly. I'll release 0.16.2 tomorrow if no other bug will be found.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.
Previous: Pavel Roskin
Message 2 of 2 in “cg-clean: fix directory cleaning”
  1. cg-clean: fix directory cleaningPavel Roskin, Dec 12, 2005
  2. Petr BaudisDec 13, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.