Re: use binmode(STDOUT) in git-status

From: Tim O'Callaghan <timo@dspsrv.com>
Date: Nov 29, 2005, 10:05 UTC
Message-ID: <20051129100550.GA2124@ELSAMSW37164>
In-Reply-To: <7vd5kkvd3q.fsf@assigned-by-dhcp.cox.net>

On Mon, Nov 28, 2005 at 10:31:05AM -0800, Junio C Hamano wrote:

Show 18 quoted lines

> Alex Riesen <raa.lkml@gmail.com> writes:
> 
> > Activision's Perl generates CRLF unless STDOUT is binmoded, which is
> > inconsistent with other output of git-status.
> 
> I do not think this is a kind of patch that I should accept to
> apply to the generic part of the codepath, even if on sane
> platforms binmode() could be a no-op.
> 
> You should not have to say binmode() when you are emitting plain
> text (otherwise you have to say that everywhere which is
> madness).  I presume the Cygwin version uses Perl from Cygwin
> and would not have this problem?
> 
> If that is the case, maybe this patch should be maintained out
> of tree by the maintainer of Windows port of git that does _not_
> use Cygwin but ActiveState.
>

You could also check `perl -v` for the phrase "built for cygwin". I am not sure how much of an issue this is though, because native windows support is going to be a bit tricky without Cygwin as you also need (ba)sh, sed, grep, etc.

Tim.