Re: [PATCH] symref support for import scripts

From: Matthias Urlichs <smurf@smurf.noris.de>
Date: Nov 16, 2005, 19:57 UTC
Message-ID: <20051116195737.GE27727@kiste.smurf.noris.de>
In-Reply-To: <7vu0ec7502.fsf@assigned-by-dhcp.cox.net>

Hi,

Junio C Hamano:

> Martin and Matthias, are these OK with you two?  All of the
> changes look trivially correct, so I'll take them.
>

IMHO: That code needs to vanish anyway.

The only reason we have to read HEAD is that, at the end of the day^Wimport, whatever HEAD points to may have been updated. Thus, we need to merge forward, to get the index back into sync.

The only thing we want to do with HEAD, in order to accomplish that, is to find the SHA1 it points to, before and after the import. No use of git-symbolic-ref is necessary for that.

All the deref code was a good idea when we actually modified the checked-out index and/or tree while importing, but that does not happen any more.

-- 
Matthias Urlichs   |   {M:U} IT Design @ m-u-it.de   |  smurf@smurf.noris.de
Disclaimer: The quote was selected randomly. Really. | http://smurf.noris.de
 - -
A good supervisor can step on your toes without messing up your shine.