git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: fix git-pack-redundant crashing sometimes

From
Alex Riesen <raa.lkml@gmail.com>
Date
Nov 15, 2005, 22:33 UTC
Message-ID
<20051115223340.GA3951@steel.home>
In-Reply-To
<437A560E.8020500@etek.chalmers.se>
Lukas Sandström, Tue, Nov 15, 2005 22:41:34 +0100:
Show 7 quoted lines
> >>llist_sorted_difference_inplace didn't handle the match in the first
> >>sha1 correctly and the lists went wild everywhere.
> > 
> > This wasn't enough. It never (>5 min on 2.4GHz PIV) finishes on
> > my local mirror of git, which has 22 packs by now.
> 
> If the patch I just sent out doesn't fix the problem, and you don't
Sorry, it doesn't. The code loops here:

401 /* find the permutations which contain all missing objects */ 402 perm_all = perm = get_all_permutations(non_unique); 403 while (perm) { 404 if (is_superset(perm->pl, missing)) { 405 new_perm = xmalloc(sizeof(struct pll)); 406 new_perm->pl = perm->pl; 407 new_perm->next = perm_ok; 408 perm_ok = new_perm; (gdb) 409 } 410 perm = perm->next; 411 } 412 413 if (perm_ok == NULL)

> want to debug it yourself, could you please publish the .idx files
> so I could have a look at them?
Of course: http://home.arcor.de/fork0/download/idx.tar.gz
Previous: Lukas SandströmNext: Lukas Sandström
Message 9 of 21 in “fix git-pack-redundant crashing sometimes”
  1. Alex RiesenNov 15, 2005
  2. Timo HirvonenNov 15, 2005
  3. Alex RiesenNov 15, 2005
  4. Linus TorvaldsNov 15, 2005
  5. Lukas SandströmNov 15, 2005
  6. Fix llist_sorted_difference_inplace in git-pack-redundantLukas Sandström, Nov 15, 2005
  7. Alex RiesenNov 15, 2005
  8. Lukas SandströmNov 15, 2005
  9. Alex RiesenNov 15, 2005
  10. Lukas SandströmNov 15, 2005
  11. Alex RiesenNov 16, 2005
  12. Alex RiesenNov 16, 2005
  13. Linus TorvaldsNov 15, 2005
  14. Junio C HamanoNov 16, 2005
  15. Lukas SandströmNov 16, 2005
  16. Lukas SandströmNov 16, 2005
  17. Matthias UrlichsNov 17, 2005
  18. Fredrik KuivinenNov 17, 2005
  19. Make git-pack-redundant non-horribly slow on large sets of packsLukas Sandström, Nov 17, 2005
  20. Fix bug introduced by the latest changes to git-pack-redundantLukas Sandström, Nov 18, 2005
  21. Fix a bug in get_all_permutations.Lukas Sandström, Nov 18, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.