Re: [PATCH] Fix empty line processing in git-shortlog.perl

From: Petr Baudis <pasky@suse.cz>
Date: Nov 7, 2005, 20:46 UTC
Message-ID: <20051107204659.GT1431@pasky.or.cz>
In-Reply-To: <7v3bm9upx4.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Mon, Nov 07, 2005 at 03:56:07AM CET, I got a letter where Junio C Hamano <junkio@cox.net> told me that...

Show 19 quoted lines

> I think the problem is deeper than that.  Shortlog summarizes to
> only one line per commit, so I suspect what you would be feeding
> it would say something like this for the above example:
> 
>         commit f1b2646c7f2713c3ea4bce120e1d0d8091808be4
>         Author: Adrian Bunk <bunk@r063144.stusta.swh.mhn.de>
> 
>             From: Michal Wronski <wrona@mat.uni.torun.pl>
> 
> That is, the commit you quoted is done by 'git log --pretty',
> but a typical shortlog invocation would be:
> 
> 	git log --pretty=short rev1..rev2 | git shortlog
> 
> With or without your fix, the command barfs.
> 
> Of course, that "From: " line should have been used as the
> commit author by the tool that created the commit out of e-mail
> Adrian received, but that is a separate issue.

Well, on a second though, I don't think we should probably handle this at all, then. The whole logic for this in git-shortlog.perl seems to be dubious, so would be a requirement that we require the input to be from --pretty=short ok?

Simpler code, no bugs, everyone happy, errors during applying (like stale From) immediately noticeable.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.