Re: git-rev-list: add "--dense" flag

From: Petr Baudis <pasky@suse.cz>
Date: Oct 22, 2005, 02:56 UTC
Message-ID: <20051022025638.GQ30889@pasky.or.cz>
In-Reply-To: <Pine.LNX.4.64.0510211814050.10477@g5.osdl.org>

Dear diary, on Sat, Oct 22, 2005 at 03:26:27AM CEST, I got a letter where Linus Torvalds <torvalds@osdl.org> told me that...

Show 8 quoted lines

> On Sat, 22 Oct 2005, Petr Baudis wrote:
> > There is no documentation for the --dense flag and it is even missing
> > from the usage string.
> 
> I'm not much for docs ;)
> 
> The whole path argument also isn't even there (and without paths, --dense 
> doesn't matter)

Then it should be added to the docs as well. ;-)

Oh well, I guess I can always send a patch when yours will get applied. :-)

Show 6 quoted lines

> > But my main concern is - will it be possible to do the rename detection
> > here as well?
> 
> Yes. Note that git-rev-list doesn't actually _do_ the diff, it only checks 
> whether the tree is changed. You still just get a list of commits out of 
> it, and it is up to you to decide what to do with it.

Ok, fair enough.

> If you're just going to feed them to diff-tree _anyway_, then you might as 
> well not even do the dense thing, because quite frankly, you're just doing 
> extra work.

fork() is awfully expensive for me. fork()ing something (supposedly) trivial (it was stat) slowed my (non-trivial) loop about 4 times. So I think it will still pay off hugely if I will be able do the diff-tree only on the interesting commits.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.