Re: [PATCH] git-daemon: timeout, eliminate double DWIM

From: Petr Baudis <pasky@suse.cz>
Date: Oct 20, 2005, 00:28 UTC
Message-ID: <20051020002845.GT30889@pasky.or.cz>
In-Reply-To: <4356966A.8010401@zytor.com>

Dear diary, on Wed, Oct 19, 2005 at 08:54:34PM CEST, I got a letter where "H. Peter Anvin" <hpa@zytor.com> told me that...

Show 14 quoted lines

> diff --git a/daemon.c b/daemon.c
> --- a/daemon.c
> +++ b/daemon.c
> @@ -13,7 +13,9 @@
>  static int log_syslog;
>  static int verbose;
>  
> -static const char daemon_usage[] = "git-daemon [--verbose] [--syslog] [--inetd | --port=n] [--export-all] [directory...]";
> +static const char daemon_usage[] =
> +"git-daemon [--verbose] [--syslog] [--inetd | --port=n] [--export-all]\n"
> +"           [--timeout=n] [--init-timeout=n] [directory...]";
>  
>  /* List of acceptable pathname prefixes */
>  static char **ok_paths = NULL;

You didn't update Documentation/git-daemon.txt.

Show 9 quoted lines

> diff --git a/upload-pack.c b/upload-pack.c
> --- a/upload-pack.c
> +++ b/upload-pack.c
> @@ -4,13 +4,19 @@
>  #include "tag.h"
>  #include "object.h"
>  
> -static const char upload_pack_usage[] = "git-upload-pack <dir>";
> +static const char upload_pack_usage[] = "git-upload-pack [--strict] [--timeout=nn] <dir>";

Ditto.

After being confronted with incomplete documentation again just minutes ago (will send patch soon), I think I'm going to start to be annoying and watch patches for this issue specifically. ;-)

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.