Re: cg-mv]

From: Zack Brown <zbrown@tumblerings.org>
Date: Oct 12, 2005, 14:28 UTC
Message-ID: <20051012142809.GA17037@tumblerings.org>
In-Reply-To: <20051012100757.GM30889@pasky.or.cz>

On Wed, Oct 12, 2005 at 12:07:57PM +0200, Petr Baudis wrote:

Show 20 quoted lines

> Dear diary, on Fri, Oct 07, 2005 at 04:33:33PM CEST, I got a letter
> where Zack Brown <zbrown@tumblerings.org> told me that...
> > Hi,
> 
> Hello,
> 
> > IIRC, file renaming is something we only care about at read time, we don't
> > actually need to track it while making the change, because git allows us to
> > track data from file to file without having to tell it that the data is moving.
> > 
> > So, just to keep certain people happy, why not have the cg-mv command defined to
> > something like this:
> > 
> > #!/bin/bash
> > cp $1 $2
> > cg-rm $1
> > cg-add $2
> 
> so it should keep the file under the original name as well, but
> untraced? That's weird.

Yes, I mistyped. cp is wrong.

Show 11 quoted lines

> What about
> 
> 	#!/usr/bin/env bash
> 
> 	if [ -e $2 ]; then
> 		! got_parameter -f && die "dest exists"
> 		[ -e $1 ] || die "no source nor destination"
> 	fi
> 	( [ -e $1 ] && mv $1 $2 ) && cg-add $2 && cg-rm $1
> 
> plus quoting and stuff?

Yes, that's nicer. Maybe the last line should be:

( [ -e $1 ] && mv $1 $2 ) && cg-add $2 && cg-rm $1 || die "unable to rename file"

But you've already done "-e $1" earlier, right? So maybe you don't need it at the end. Just have:

mv $1 $2 && cg-add $2 && cg-rm $1 || die "unable to rename file"

No?

Be well, Zack

Show 6 quoted lines

> 
> -- 
> 				Petr "Pasky" Baudis
> Stuff: http://pasky.or.cz/
> VI has two modes: the one in which it beeps and the one in which
> it doesn't.

-- 
Zack Brown