Re: [PATCH] Fix gcc-4 warning in accept() call
Pavel Roskin <proski@gnu.org> wrote:
Show 18 quoted lines
> Fix gcc-4 warning in accept() call
>
> gcc-4 warns about sign mismatch in pointers. Third argument in accept()
> is socklen_t, which is unsigned. Since Linus doesn't like socklen_t
> (see commit 7fa090844f7d1624c7d1ffc621aae6aec84a1110), let's use
> unsigned int.
>
> Signed-off-by: Pavel Roskin <proski@gnu.org>
>
> diff --git a/daemon.c b/daemon.c
> --- a/daemon.c
> +++ b/daemon.c
> @@ -459,7 +459,7 @@ static int serve(int port)
>
> if (FD_ISSET(sockfd, &fds)) {
> struct sockaddr_storage ss;
> - int sslen = sizeof(ss);
> + unsigned int sslen = sizeof(ss);Shouldn't this be size_t?
> int incoming = accept(sockfd, (struct sockaddr *)&ss, &sslen);
> if (incoming < 0) {
> switch (errno) {--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria +56 32 654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513
Horst von Brand <vonbrand@inf.utfsm.cl>