Re: first impressions to git

From: Kay Sievers <kay.sievers@vrfy.org>
Date: Sep 18, 2005, 21:39 UTC
Message-ID: <20050918213913.GC13315@vrfy.org>
In-Reply-To: <20050918211855.GA1463@schottelius.org>

On Sun, Sep 18, 2005 at 11:18:56PM +0200, Nico -telmich- Schottelius wrote:

> First of all, thanks for that many very good explaining answers.

Show 7 quoted lines

> Than I tried gitweb.cgi, which seems to have a small bug validating input:
> 
>    if ($input =~ m/(^|\/)(|\.|\.\.)($|\/)/) {
> 
> This also matches a cLinux/cinit.git as far as I can see.
> I use '(^|\/)(\.\.|\.)($|\/)' currently, but I am not totally sure, whether
> this is correct.

It fails cause you have a "non canonical" file name with a trailing slash.

Show 6 quoted lines

> You can see the original version on
> http://linux.schottelius.org/cgi-bin/gitweb-orig.cgi
> and my modified version on
> http://linux.schottelius.org/cgi-bin/gitweb.cgi
> 
> But perhaps the logic in gitweb.cgi should be changed:

Just remove the trailing slash from your project name and everything should be fine.

Kay