git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[patch 04/11] Fix "mail" command when description contains "From" lines

From
PGPaolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Date
Sep 16, 2005, 19:35 UTC
Message-ID
<20050916193516.18681.83723.stgit@zion.home.lan>
In-Reply-To
<20050916193511.18681.24189.stgit@zion.home.lan>

For kernel patches, the "From" line from the email is often preserved in the patch itself, and the one from the email is sometimes lost, so I add an explicit one. And mail barfes on this. Fix it up.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
---
 stgit/commands/mail.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/stgit/commands/mail.py b/stgit/commands/mail.py
--- a/stgit/commands/mail.py
+++ b/stgit/commands/mail.py
@@ -122,7 +122,7 @@ def __parse_addresses(string):
         elif re.match('(to|cc|bcc):\s+', line, re.I):
             to_addr_list += __addr_list(line)
 
-    if len(from_addr_list) != 1:
+    if len(from_addr_list) == 0:
         raise CmdException, 'No "From" address'
     if len(to_addr_list) == 0:
         raise CmdException, 'No "To/Cc/Bcc" addresses'
Previous: Paolo 'Blaisorblade' GiarrussoNext: Paolo 'Blaisorblade' Giarrusso
Message 5 of 12 in “Fix typo: comitter->committer”
  1. 01/11 Fix typo: comitter->committerPaolo 'Blaisorblade' Giarrusso, Sep 16, 2005
  2. 02/11 Make "empty patch" checking optional in "series" command.Paolo 'Blaisorblade' Giarrusso, Sep 16, 2005
  3. Catalin MarinasSep 17, 2005
  4. 03/11 stg diff / files: don't update directory cache unless neededPaolo 'Blaisorblade' Giarrusso, Sep 16, 2005
  5. 04/11 Fix "mail" command when description contains "From" linesPaolo 'Blaisorblade' Giarrusso, Sep 16, 2005
  6. 05/11 Make "stg files" output match "quilt files" onePaolo 'Blaisorblade' Giarrusso, Sep 16, 2005
  7. 06/11 Avoid allowing --undo if it doesn't change anythingPaolo 'Blaisorblade' Giarrusso, Sep 16, 2005
  8. 07/11 Implement fast-forward when only tree (but not commits) matchPaolo 'Blaisorblade' Giarrusso, Sep 16, 2005
  9. 08/11 Fix "stg clean" when stack is emptyPaolo 'Blaisorblade' Giarrusso, Sep 16, 2005
  10. 09/11 Allow mailing a given patch listPaolo 'Blaisorblade' Giarrusso, Sep 16, 2005
  11. 10/11 Fix "stg mail" address parsing for hyphenPaolo 'Blaisorblade' Giarrusso, Sep 16, 2005
  12. 11/11 Detect description in quilt patchesPaolo 'Blaisorblade' Giarrusso, Sep 16, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.