Re: A simple script to do the reverse of git-push

From: Petr Baudis <pasky@suse.cz>
Date: Aug 11, 2005, 22:18 UTC
Message-ID: <20050811221812.GG25280@pasky.ji.cz>
In-Reply-To: <7vslxk125f.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Tue, Aug 09, 2005 at 12:42:36AM CEST, I got a letter where Junio C Hamano <junkio@cox.net> told me that...

Show 19 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > BTW, if you are lazy, like me, you just pull from Junio once in a while 
> > and do a "make test". Turns out there is a missing dependency though:
> >
> > peek-remote.o: cache.h
> >
> > which in my case lead to a git-peek-remote program which was unable to 
> > peek any ref.
> 
> You are right.  Thanks for noticing.
> 
>     $ (make clean ; make ) >/dev/null 2>/dev/null
>     $ touch cache.h
>     $ make 2>&1 | grep peek-remote
>     cc -g -O2 -Wall  '-DSHA1_HEADER=<openssl/sha.h>' -o git-peek-remote peek-remote.o libgit.a -lz -lcrypto
> 
> I think recent "depend on object files" Makefile patch broke
> some things.

Indeed. I took care to make the new dependencies a superset of previous situation when removing the explicit dependencies list, but before, rebuilding of libgit.a caused rebuilt from source of all the commands, which wouldn't happen anymore after adding the object files, which this way sneakily removed an implicit dependency of the command sources on $(LIB_H). Eek.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
If you want the holes in your knowledge showing up try teaching
someone.  -- Alan Cox