Re: qgit-0.7
- From
- Marco Costalba <mcostalba@yahoo.it>
- Date
- Jul 9, 2005, 15:06 UTC
- Message-ID
- <20050709150621.51442.qmail@web26310.mail.ukl.yahoo.com>
Wolfgang Denk ha scritto:
Show 15 quoted lines
>Dear Marco, > >in message <20050709081512.33503.qmail@web26306.mail.ukl.yahoo.com> you wrote: > >>Here is qgit-0.7, a GUI git viewer. > > >Sorry, but I cannot compile it on a Fedora Core 4 system: > >-> ./configure >+scons was found, that's excellent+ >scons: Reading SConscript files ... >-> make >scons -Q >g++ -DQT_THREAD_SUPPORT -D_REENTRANT -I/usr/lib64/qt-3.3/include -c -o src/annotate.o
src/annotate.cpp
Show 30 quoted lines
>src/annotate.cpp: In member function `QStringList Annotate::processDiff(const
> QString&, QStringList&, const QString&)':
>src/annotate.cpp:378: error: jump to case label
>src/annotate.cpp:373: error: crosses initialization of `int num'
>src/annotate.cpp:387: error: jump to case label
>src/annotate.cpp:373: error: crosses initialization of `int num'
>src/annotate.cpp:401: error: jump to case label
>src/annotate.cpp:373: error: crosses initialization of `int num'
>scons: *** [src/annotate.o] Error 1
>make: *** [all] Error 2
>
>The following patch solves this problem:
>
>--- src/annotate.cpp.ORIG 2005-07-09 07:10:23.000000000 +0200
>+++ src/annotate.cpp 2005-07-09 16:05:09.556653902 +0200
>@@ -370,10 +370,12 @@
> char firstChar = line[0].latin1();
> switch (firstChar) {
> case '@':
>+ {
> int num = line.section(',', 1, 1). section('+', 1, 1).toInt();
> // diff lines start from 1, 0 is empty file,
> // instead QValueList::at() starts from 0
> cur = (num > 0) ? newAnn.at(num - 1) : newAnn.end();
>+ }
> break;
> case '+':
> if (cur != newAnn.end()) {
>
>Thanks for your patch, applied.
What version og gcc you have? Mine is gcc version 4.0.1 and I don't have this compile error (of course ;-) ).
I have cc'ed to git@vger.kernel.org in case someone else have the same problem.
Show 22 quoted lines
>With this patch, I get a lot of build errors: > >QSettings: error creating /.qt >QSettings: error creating /.qt >QSettings: error creating /.qt >QSettings: error creating /.qt >QSettings: error creating /.qt >QSettings::sync: filename is null/empty >QSettings: error creating /.qt >QSettings::sync: filename is null/empty >QSettings: error creating /.qt >QSettings::sync: filename is null/empty >QSettings: error creating /.qt >QSettings::sync: filename is null/empty >QSettings: error creating /.qt >QSettings::sync: filename is null/empty >QSettings: error creating /.qt >QSettings::sync: filename is null/empty >... > >It links and seems to run, though. >
It's a known issue, probably due to scons setup, but I am not so familiar with scons to find a fix, in any case should be absolutely painless.
Marco
__________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com