git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Remove use of SHOWN flag

From
Jon Seymour <jon.seymour@gmail.com>
Date
Jul 7, 2005, 02:00 UTC
Message-ID
<20050707020024.7874.qmail@blackcubes.dyndns.org>

Now that duplicates are elided early, there is no need for the SHOWN flag.

This patch removes the SHOWN flag and its uses from rev-list.c
Signed-off-by: Jon Seymour <jon.seymour@gmail>
---
 rev-list.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
28294b1e139ea3f7c08814e022246e42f9ab9fa3
diff --git a/rev-list.c b/rev-list.c
--- a/rev-list.c
+++ b/rev-list.c
@@ -8,7 +8,6 @@
 #define SEEN		(1u << 0)
 #define INTERESTING	(1u << 1)
 #define COUNTED		(1u << 2)
-#define SHOWN		(1u << 3)
 
 static const char rev_list_usage[] =
 	"usage: git-rev-list [OPTION] commit-id <commit-id>\n"
@@ -42,7 +41,6 @@ static int topo_order = 0;
 
 static void show_commit(struct commit *commit)
 {
-	commit->object.flags |= SHOWN;
 	if (show_breaks) {
 		prefix = "| ";
 		if (commit->object.flags & DISCONTINUITY) {
@@ -72,7 +70,7 @@ static int filter_commit(struct commit *
 {
 	if (stop_traversal && (commit->object.flags & BOUNDARY))
 		return STOP;
-	if (commit->object.flags & (UNINTERESTING|SHOWN))
+	if (commit->object.flags & UNINTERESTING)
 		return CONTINUE;
 	if (min_age != -1 && (commit->date > min_age))
 		return CONTINUE;
------------
Message 1 of 1 in “Remove use of SHOWN flag”
  1. Remove use of SHOWN flagJon Seymour, Jul 7, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.