Re: cvsimport: rewritten in Perl
- From
- Sven Verdoolaege <skimo@kotnet.org>
- Date
- Jul 6, 2005, 06:37 UTC
- Message-ID
- <20050706063712.GV18608MdfPADPa@garage.linux.student.kuleuven.ac.be>
- In-Reply-To
- <Pine.LNX.4.58.0507051936350.3570@g5.osdl.org>
On Tue, Jul 05, 2005 at 07:41:30PM -0700, Linus Torvalds wrote:
Show 8 quoted lines
> If you make it print out its <pid> and then pause, you can use > > ls -l /proc/<pid>/fd/ > > to get an idea of what the files may be. Looks like the new perl version > is leaking file descriptors.. > > Matthias?
That was my mistake, actually. Thanks for spotting this.
skimo -- git-cvsimport-script: close temporary file.
--- commit 6b6fdaa290f7dfd178a518fcafb9e14e652eb8ac tree 725e7c6ecc75a0e90a6bc002ce540bd74dca999e parent f4b3a4c30b5ea3a5de2a2597a3c53266017d02ba author Sven Verdoolaege <skimo@kotnet.org> Wed, 06 Jul 2005 08:01:47 +0200 committer Sven Verdoolaege <skimo@kotnet.org> Wed, 06 Jul 2005 08:01:47 +0200
git-cvsimport-script | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git-cvsimport-script b/git-cvsimport-script --- a/git-cvsimport-script +++ b/git-cvsimport-script @@ -317,6 +317,7 @@ sub file { $res = $self->_line($fh); die "No input: $fn $rev\n" unless defined $res; } + close ($fh); return ($name, $res); }