Re: [PATCH] Rewrite cg-diff colorization, add diffstat and reverse

From: Petr Baudis <pasky@ucw.cz>
Date: Jun 12, 2005, 07:29 UTC
Message-ID: <20050612072927.GA6620@pasky.ji.cz>
In-Reply-To: <42AAF54C.3010908@gmail.com>

Dear diary, on Sat, Jun 11, 2005 at 04:29:32PM CEST, I got a letter where Dan Holmsand <holmsand@gmail.com> told me that...

Show 22 quoted lines

> Petr Baudis wrote:
> >Dear diary, on Thu, Jun 09, 2005 at 01:24:07PM CEST, I got a letter
> >where Dan Holmsand <holmsand@gmail.com> told me that...
> >
> >I'm sorry, but those two patches are still way too big and therefore
> >basically unreviewable. Could you please split them further to a
> >per-feature patches?
> >
> >A good place to start would be changing the [PATCH 2/6] color refactor
> >to actually _replace_ the color stuff of cg-log and cg-diff with the new
> >common cg-Xlib code - but please don't change the default colors in that
> >patch yet (that is because you shouldn't assume in your earlier patches
> >that later patches will be applied, or applied in the form you send
> >them; I don't know about the less search thing yet, since I didn't test
> >it, since I don't have a focused patch for it).,
> 
> Ok, here's another one to start with.
> 
> cg-diff only, this time around. It's much simpler, since cg-diff got a 
> lot more similar to your stuff due to your excellent optparse-ification.
> 
> If this is still too big, I'm not really sure how to go about this.

Well, would it be a problem to first do the color handling separately, as I suggested? Also, you bundle in a bunch of non-vital cleanups - nothing wrong about them but they are really cluttering the patch up and you could do them separately.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
<Espy> be careful, some twit might quote you out of context..