Re: [PATCH 3/6] Make showdate use "Linus format"
- From
Petr Baudis <pasky@ucw.cz>
- Date
- Jun 10, 2005, 22:59 UTC
- Message-ID
- <20050610225938.GE22111@pasky.ji.cz>
- In-Reply-To
- <42A825C2.1060302@gmail.com>
Thanks, applied.
Dear diary, on Thu, Jun 09, 2005 at 01:19:30PM CEST, I got a letter where Dan Holmsand <holmsand@gmail.com> told me that...
> This makes showdate use the same date format as > git-rev-list --pretty, and gives some speedup. It might also > be more portable.
I dropped the format change bit, because I really think the Linus' date format is bad. The current standardized, international and most widely used (even your mailer agent used it in your Date: header) date format is RFC 822, so please let's stick with it. It's perfect for our use, and better human-readable too. The date part isn't split all around but concentrated in the first half while the second half is dedicated to time.
> Note that this changes the calling convention: the previous > version used seconds from $1, but timezone from the global > variable $date. cg-mkpatch is modified to the new way.
You forgot to modify cg-log accordingly. (I fixed that.)
-- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ <Espy> be careful, some twit might quote you out of context..