Re: [ANNOUNCE] Cogito-0.11.3

From: Chris Wright <chrisw@osdl.org>
Date: Jun 9, 2005, 21:06 UTC
Message-ID: <20050609210641.GK5324@shell0.pdx.osdl.net>
In-Reply-To: <20050609205503.GJ5324@shell0.pdx.osdl.net>

* Chris Wright (chrisw@osdl.org) wrote:

Show 9 quoted lines

> * Dan Holmsand (holmsand@gmail.com) wrote:
> > Konstantin Antselovich wrote:
> > >I have updated to Cogito-0.11.3, it compiles and runs
> > >but make test returns multiple error messages (see below)
> > 
> > There's a typo in rev-list.c. This fixes the tests for me:
> 
> This patch is white space damaged.  I fixed it, and added it to the
> cogito-0.11.3 rpm.  Below is the refreshed patch.

Looks like showdate() is having some minor trouble. A simple cg-log gave me errors indicating the tz is being interpreted as octal. There's probably a better way, but bruteforce works ;-) This patch is in the RPM packages which are now uploading.

thanks, -chris --

Strip leading zero from timezone to keep it from being interpreted as octal causing error such as:

/usr/lib/cogito/cg-Xlib: line 69: 0800: value too great for base (error token is "0800")

Signed-off-by: Chris Wright <chrisw@osdl.org>

--- a/cg-Xlib
+++ b/cg-Xlib
@@ -65,7 +65,9 @@ showdate () {
 	[ "$format" ] || format=-R
 	sec=${date[0]}; tz=${date[1]}
 	if [ "$has_gnudate" ]; then
-	        dtz=${tz/+/}
+	        dtz=${tz/-0/-}
+	        dtz=${dtz/+/}
+	        dtz=${dtz/#0/}
 		lsec=$(($dtz / 100 * 3600 + $dtz % 100 * 60 + $sec))
 	        pdate="$(date -ud "1970-01-01 UTC + $lsec sec" "$format" 2>/dev/null)"
 	else