git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/10] Cleanup conversion to human readable date

From
Jonas Fonseca <fonseca@diku.dk>
Date
Jun 4, 2005, 14:39 UTC
Message-ID
<20050604143906.GE12615@diku.dk>
In-Reply-To
<20050604143831.GD12615@diku.dk>
Simplify the date substitution to reduce code duplication.
Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
---
 cg-log     |    8 ++------
 cg-mkpatch |    7 ++-----
 2 files changed, 4 insertions(+), 11 deletions(-)
diff --git a/cg-log b/cg-log
--- a/cg-log
+++ b/cg-log
@@ -188,12 +188,8 @@ $revls | $revsort | while read time comm
 
 				date=(${rest#*> })
 				pdate="$(showdate $date)"
-				if [ "$pdate" ]; then
-					echo -n $color$key $rest | sed "s/>.*/> $pdate/"
-					echo $coldefault
-				else
-					echo $color$key $rest $coldefault
-				fi
+				[ "$pdate" ] && rest="${rest%> *}> $pdate"
+				echo $color$key $rest $coldefault
 				;;
 			"tree"|"parent")
 				if [ -z $tree1 ]; then
diff --git a/cg-mkpatch b/cg-mkpatch
--- a/cg-mkpatch
+++ b/cg-mkpatch
@@ -53,11 +53,8 @@ showpatch () {
 		"author"|"committer")
 			date=(${rest#*> })
 			pdate="$(showdate $date)"
-			if [ "$pdate" ]; then
-				echo $key $rest | sed "s/>.*/> $pdate/" >>$header
-			else
-				echo $key $rest >>$header
-			fi
+			[ "$pdate" ] && rest="${rest%> *}> $pdate"
+			echo $key $rest >>$header
 			;;
 		"")
 			cat
-- 
Jonas Fonseca
Previous: Jonas FonsecaNext: Jonas Fonseca
Message 2 of 11 in “[PATCHSET] cg-log cleanups and enhancements”
  1. Jonas FonsecaJun 4, 2005
  2. 1/10 Cleanup conversion to human readable dateJonas Fonseca, Jun 4, 2005
  3. 2/10 Separate handling of tree and parent in commit headersJonas Fonseca, Jun 4, 2005
  4. 3/10 Separate handling of author and committer in commit headersJonas Fonseca, Jun 4, 2005
  5. 4/10 First parse all commit header entries then print themJonas Fonseca, Jun 4, 2005
  6. 5/10 Move printing of the commit info line inside the loopJonas Fonseca, Jun 4, 2005
  7. 6/10 Remove the catch all ruleJonas Fonseca, Jun 4, 2005
  8. 7/10 Move log printing to separate functionJonas Fonseca, Jun 4, 2005
  9. 8/10 Move the username matching inside the loopJonas Fonseca, Jun 4, 2005
  10. 9/10 Move file matching inside the loop.Jonas Fonseca, Jun 4, 2005
  11. 10/10 Add -s option to show log summaryJonas Fonseca, Jun 4, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.