git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix use of wc in t0000-basic

From
HXHerbert Xu <herbert@gondor.apana.org.au>
Date
May 21, 2005, 11:01 UTC
Message-ID
<20050521110129.GA7924@gondor.apana.org.au>
In-Reply-To
<7vhdgwj1ed.fsf@assigned-by-dhcp.cox.net>
On Sat, May 21, 2005 at 03:53:30AM -0700, Junio C Hamano wrote:
Show 8 quoted lines
> >>>>> "HX" == Herbert Xu <herbert@gondor.apana.org.au> writes:
> 
> HX> It's also better to use -eq instead of = since you are comparing
> HX> numbers, not strings.  If you do that you can keep the double
> HX> quotes since the spaces will be removed automatically.
> 
> I remember being burned by busybox "test" which did not ignore
> spaces.  I do not know if the latest one is fixed, though.

Are you sure that it didn't ignore the leading spaces with -eq? The code in question just calls strtol.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Previous: Junio C HamanoNext: Junio C Hamano
Message 9 of 10 in “Fix use of wc in t0000-basic”
  1. Fix use of wc in t0000-basicDaniel Barkalow, May 21, 2005
  2. SeanMay 21, 2005
  3. Daniel BarkalowMay 21, 2005
  4. SeanMay 21, 2005
  5. Daniel BarkalowMay 21, 2005
  6. Junio C HamanoMay 21, 2005
  7. Herbert XuMay 21, 2005
  8. Junio C HamanoMay 21, 2005
  9. Herbert XuMay 21, 2005
  10. Junio C HamanoMay 21, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.