Re: [PATCH Cogito] Improve option parsing for cg-log
- From
Petr Baudis <pasky@ucw.cz>
- Date
- May 17, 2005, 20:16 UTC
- Message-ID
- <20050517201658.GD7136@pasky.ji.cz>
- In-Reply-To
- <1115975134.18499.94.camel@pegasus>
Dear diary, on Fri, May 13, 2005 at 11:05:34AM CEST, I got a letter where Marcel Holtmann <marcel@holtmann.org> told me that...
> Hi Petr,
Hi,
Show 5 quoted lines
> > The -r option still must be after all the other options. > > I see what you mean and it seems that I missed that option. Must be > because you put the list_commit_files() between them and I assumed that > there is no further option parsing.
Uhm, I know. :-) It sorta evolved like that. We didn't yet settle down on where to actually put the functions. I'd say right after . cg-Xlib.
> Do you really wanna keep the double meaning of -r. Depending on a > previous -r it is $log_start or $log_end.
Yes, by all means. On one side I like the colon notation, on the other side this was always my biggest usability problem with SVN. And it costs us nothing and does what the user would after all expect, I think.
-- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor