git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: rev-list/tree committer/author information.

From
Petr Baudis <pasky@ucw.cz>
Date
May 16, 2005, 22:19 UTC
Message-ID
<20050516221957.GD8609@pasky.ji.cz>
In-Reply-To
<7vekc6onzc.fsf_-_@assigned-by-dhcp.cox.net>

Dear diary, on Mon, May 16, 2005 at 11:33:11PM CEST, I got a letter where Junio C Hamano <junkio@cox.net> told me that...

Show 24 quoted lines
> >>>>> "LT" == Linus Torvalds <torvalds@osdl.org> writes:
> 
> LT> Anyway, everything I've read so far makes sense, and it
> LT> might make sense to continue git development using just
> LT> git-pb. The only thing I personally think sucks is the
> LT> author/committer matching of git-rev-list/tree, since it
> LT> would seem like somebody might well like to match on an
> LT> arbitrary part of a commit, and special-casing
> LT> author/committer seems somewhat broken.
> 
> Well, that author/committer thing is not in git-pb yet, if I am
> not mistaken [*1].
> 
> The only reason why I did it that way was because the strategy
> taken by "struct object" derivatives seemed to pick up bare
> absolute minimum to support actual callers that have immediate
> need for information stored in structural fields, as opposed to
> designing for helping yet to be written callers by adding fields
> to hold information of "having this might also help somebody in
> the future" type.  And the author and committer names are in the
> structured fields while signed-off-by and others are not.  Also
> when author / committer name strings are intern'ed like the way
> I did, the memory consumption even for a long sequence of
> commits are kept reasonably low.  However,...

I like Linus' suggestion. At the very least, what about making the matching generic for the header? Something like --match-header or whatever.

Show 7 quoted lines
> *1* Petr has been applying quite good judgements. I would have
> polluted git-jc with that patch already if I were still running
> it.  So far, I have been generally happy with his acceptance
> criteria for external patches.  Anything he places on hold or
> just outright returns to me, I later find rooms for improvements
> myself, and the later rounds that eventually get accepted always
> turn out to be far cleaner, thanks to his comments.

Thanks for the praise :-), but I'm actually quite unhappy with putting patches "on hold" and it's not intentional. It's just that I don't feel right about the patch enough to apply it immediately, and I either don't have time to voice my concerns if they are non-trivial, or I just want some time to think about it.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor
Previous: Junio C HamanoNext: Daniel Barkalow
Message 4 of 28 in “Summary of core GIT while you are away.”
  1. Junio C HamanoMay 14, 2005
  2. Linus TorvaldsMay 16, 2005
  3. rev-list/tree committer/author information.Junio C Hamano, May 16, 2005
  4. Petr BaudisMay 16, 2005
  5. Daniel BarkalowMay 16, 2005
  6. Junio C HamanoMay 16, 2005
  7. Petr BaudisMay 16, 2005
  8. Kay SieversMay 26, 2005
  9. Junio C HamanoMay 26, 2005
  10. Linus TorvaldsMay 26, 2005
  11. Linus TorvaldsMay 26, 2005
  12. Kay SieversMay 26, 2005
  13. Junio C HamanoMay 26, 2005
  14. Kay SieversMay 26, 2005
  15. Junio C HamanoMay 26, 2005
  16. H. Peter AnvinMay 27, 2005
  17. Junio C HamanoMay 27, 2005
  18. H. Peter AnvinMay 27, 2005
  19. Junio C HamanoMay 27, 2005
  20. H. Peter AnvinMay 27, 2005
  21. Junio C HamanoMay 27, 2005
  22. Linus TorvaldsMay 27, 2005
  23. H. Peter AnvinMay 26, 2005
  24. Junio C HamanoMay 26, 2005
  25. Kay SieversMay 26, 2005
  26. Junio C HamanoMay 27, 2005
  27. Kay SieversMay 27, 2005
  28. Junio C HamanoMay 27, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.