Re: [PATCH] Ignore file filter

From: Petr Baudis <pasky@ucw.cz>
Date: May 14, 2005, 12:21 UTC
Message-ID: <20050514122134.GF3905@pasky.ji.cz>
In-Reply-To: <4285B6A8.4080309@dgreaves.com>

Dear diary, on Sat, May 14, 2005 at 10:28:24AM CEST, I got a letter where David Greaves <david@dgreaves.com> told me that...

Show 10 quoted lines

> >>#. ${COGITO_LIB}cg-Xlib
> >>_git=${GIT_DIR:-.git}
> >>    
> >>
> >
> >...but it makes no sense anyway I think to reinclude this stuff from a
> >cg-Xfile you are including from other scripts anyway.
> >  
> >
> cg-Xignore isn't included - only called.

Oh yes, I'm stupid.

> it's also just a library program.
> Also I don't think cg-Xlib should be doing arg handling.
> As an include it should provide an arg handling function that the
> scripts call.

I'd prefer the few and scattered users which don't want arg handling to explicitly set some magic variable before calling cg-Xlib rather than adding the arg parser function call everywhere else.

Show 15 quoted lines

> >>	    if [[ $file =~ $patt ]]; then
> >>    
> >>
> >
> >I'm sorry but this is really nothing my bash-2.05.0(1)-release supports.
> >We're already bash-only, but further reducing that to bash3 really won't
> >work. I *might* get convinced to add some bash2+-only feature, but only
> >if you'll be really good at explaining that it makes sense.
> >  
> >
> Ah
> OK
> I don't know how to do that.
> I was actually aiming for glob matching when I came upon this in the
> manpage.

Ok, so what's the outcome? Are you going to stop at this point, or will you change the scripts so that they use the glob list?

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor