Re: [PATCH Cogito] Make use of external editor work like CVS

From: Petr Baudis <pasky@ucw.cz>
Date: May 9, 2005, 07:33 UTC
Message-ID: <20050509073333.GC3599@pasky.ji.cz>
In-Reply-To: <20050509052814.617dceac.froese@gmx.de>

Dear diary, on Mon, May 09, 2005 at 05:28:14AM CEST, I got a letter where Edgar Toernig <froese@gmx.de> told me that...

Show 15 quoted lines

> Petr Baudis wrote:
> >
> > > +               if ! [ $LOGMSG2 -nt $LOGMSG ]; then
> > > +                       rm $LOGMSG $LOGMSG2
> > > +                       die 'Commit message not modified, commit aborted'
> > > +               fi
> 
> Just in case you come to a conclusion some day, how about changing the
> if-test to
> 
> 	if cmp -s $LOGMSG LOGMSG2; then
> 
> ?  :-)  IMHO much better then comparing only the date.
> 
> Ciao, ET.

Much, much worse. What if I really actually do not want to change anything in the merge message or the series of -m's? Ok, :x didn't work now since we cannot know. But now, :wq won't do either, and you actually need to do some silly dummy change now.

I think we should really ask the user as CVS, as Marcel (or whoever) suggested.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor