Re: [PATCH] Add cg-printenv command.
- From
Petr Baudis <pasky@ucw.cz>
- Date
- May 9, 2005, 07:24 UTC
- Message-ID
- <20050509072438.GB3599@pasky.ji.cz>
- In-Reply-To
- <200505082159.59595.elenstev@mesatop.com>
Dear diary, on Mon, May 09, 2005 at 05:59:59AM CEST, I got a letter where Steven Cole <elenstev@mesatop.com> told me that...
Show 10 quoted lines
> On Sunday 08 May 2005 09:40 pm, Sean wrote: > > On Sun, May 8, 2005 11:25 pm, Steven Cole said: > > > > > I had intended it only as a quick check by an end-user before doing > > > a commit that the values had been set as desired. > > > > Hey Steven, > > > > Rather than creating a separate command, perhaps the values could > > automatically be added to the initial commit message in a few "CG:" lines?
I was already thinking about this and I think Sean's way makes more sense. Also, I actually believe you should add this functionality to commit-tree instead (commit-tree -n (dry-run), perhaps?) - so that the user can actually check the default values commit-tree is going to use too. *That* would be useful.
> A secondary reason for adding the cg-printenv capability was that a user would > see this command in the cg-help list, and cg-help printenv would give:
No, I think this sucks. You should just list the variables in cg-commit documentation if anything. That's where they matter anyway and where the user could possibly look for them anyway.
I think the command is otherwise pretty useless, and the important thing is, the command slots are precious (well, there are free cg-admin slots but I think this one does not qualify there neither) - have too many useless (or barely useful) commands and you end up as GNU Arch. So I'm willing to add commands only when I'm convinced they will really help the user.
-- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor