Re: [PATCH] fix compare symlink against readlink not data
- From
Greg KH <greg@kroah.com>
- Date
- May 6, 2005, 16:36 UTC
- Message-ID
- <20050506163603.GA17766@kroah.com>
- In-Reply-To
- <1115396614.32065.23.camel@localhost.localdomain>
On Fri, May 06, 2005 at 06:23:34PM +0200, Kay Sievers wrote:
Show 20 quoted lines
> On Fri, 2005-05-06 at 09:03 -0700, Greg KH wrote: > > On Fri, May 06, 2005 at 03:45:01PM +0200, Kay Sievers wrote: > > > Fix update-cache to compare the blob of a symlink against the link-target > > > and not the file it points to. Also ignore all permissions applied to > > > links. > > > Thanks to Greg for recognizing this while he added our list of symlinks > > > back to the udev repository. > > > > Hm, even with this patch applied (it's in Linus's tree right now), I > > still get the following with a clean checked out udev tree: > > $ cg-diff > > Index: test/sys/block/cciss!c0d0/device > > =================================================================== > > I can't reproduce this. Are you sure, that the git-core binaries are > called and not the cogito ones? > > git-update-cache --refresh > git-diff-cache -r HEAD > from the core-git should print nothing.
Odd. If I reclone the whole tree from the udev kernel.org tree, then it works just fine. If I create a new copy of my local tree, I still have the same problem. Diffing the trees shows no difference in the objects at all...
Can you add a symlink to a local tree and see if you can duplicate this?
thanks,
greg k-h