Re: Next problem: cg-commit

From: Petr Baudis <pasky@ucw.cz>
Date: May 2, 2005, 22:30 UTC
Message-ID: <20050502223031.GG20818@pasky.ji.cz>
In-Reply-To: <20050429215118.D30010@flint.arm.linux.org.uk>

Dear diary, on Fri, Apr 29, 2005 at 10:51:18PM CEST, I got a letter where Russell King <rmk@arm.linux.org.uk> told me that...

Show 15 quoted lines

> Unfortunately, cg-commit seems to return wrong exit status, returning
> 1 on success.  Eg:
> 
> $ cg-commit
> arch/arm/mach-ixp2000/pci.c
> include/asm-arm/arch-ixp2000/platform.h
> Enter commit message, terminated by ctrl-D on a separate line:
> blah blah blah
> Committed as fafb525292acc9c0818b91b1d8e58cf770616542.
> $ echo $?
> 1
> 
> It appears that [ "$merging" ] towards the end of cg-commit is the
> cause of this odd behaviour.  Force zero exit status, since we
> successfully completed.

Nice find, thanks. I added it to few other files too.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor